feat(helm): add ServiceAccount support to mcp-stack chart #1718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppippi-dev
force-pushed
the
feature/helm-serviceaccount-support
branch
from
4df2b8a to
c861fdf
Compare
Add optional ServiceAccount configuration for cloud IAM integration (AWS IRSA, GCP Workload Identity). Disabled by default to maintain backward compatibility. - Add serviceAccount section to values.yaml - Add serviceAccountName helper to _helpers.tpl - Create serviceaccount.yaml template - Attach serviceAccountName to all Deployments and Jobs - Add schema validation in values.schema.json Signed-off-by: ppippi-dev <[email protected]>
The original PR missed adding serviceAccountName to the pgbouncer deployment template. This adds it for consistency with all other deployments and jobs in the chart. Signed-off-by: Mihai Criveti <[email protected]>
- Add CHANGELOG entry for ServiceAccount support feature - Add helm-docs comments to serviceAccount values for auto-generated docs - Document that automountServiceAccountToken only applies when create=true - Document that all pods share the same ServiceAccount - Regenerate README.md with helm-docs to include new values Signed-off-by: Mihai Criveti <[email protected]>
crivetimihai
force-pushed
the
feature/helm-serviceaccount-support
branch
from
c861fdf to
96aecd8
Compare
crivetimihai
approved these changes
Jan 13, 2026
Member
|
Thanks for this contribution @ppippi-dev! 🎉 I've rebased the PR onto main and made a few additional changes: Fix:
Documentation:
The PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
serviceAccount.create: false) to maintain backward compatibilityChanges
values.yamlserviceAccountsection withcreate,name,annotations,automountServiceAccountToken_helpers.tplmcp-stack.serviceAccountNamehelper functionserviceaccount.yamlcreate: true)values.schema.jsonserviceAccountNamereferenceserviceAccountNamereferenceUsage Example
Validation
helm lintpasseshelm templaterenders correctly with default valueshelm template --set serviceAccount.create=truecreates ServiceAccount resource